Only prefer interpolated string handler conversions in C# 10 #55380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dotnet#55345. Note that we will still know about the conversion, meaning that if a library introduces an interpolated string handler overload and has another overload with a conversion that is not "better" than any other conversion, such as an overload between `Span<char>` and `CustomHandler`, that code will be considered ambiguous and not compile. I think that is fine though, as 99% of these cases will be overloads between `string` and `CustomHandler`, not `Span<char>` and `CustomHandler`.
jaredpar
approved these changes
Aug 3, 2021
333fred
commented
Aug 3, 2021
| IL_002b: ldloc.0 | ||
| IL_002c: call ""void C.M(CustomHandler)"" | ||
| IL_0031: ret | ||
| IL_0000: call ""void CultureInfoNormalizer.Normalize()"" |
There was a problem hiding this comment.
Only change in the IL here is this line. Otherwise, C# 10 remains the same.
cston
reviewed
Aug 3, 2021
src/Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/OverloadResolution.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Aug 3, 2021
333fred
force-pushed
the
prefer-string-in-9
branch
from
774729a to
3e4dbde
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55345. Note that we will still know about the conversion, meaning that if a library introduces an interpolated string handler overload and has another overload with a conversion that is not "better" than any other conversion, such as an overload between
Span<char>andCustomHandler, that code will be considered ambiguous and not compile. I think that is fine though, as 99% of these cases will be overloads betweenstringandCustomHandler, notSpan<char>andCustomHandler.Test plan: #51499