Move IsBuildOnlyDiagnostic to use a switch expression (#73313)

By suppressing CS8524, we can get a build-time diagnostic when we forget to update this, rather than getting a test failure that we often forget until CI throws.

Co-authored-by: Rikki Gibson <[email protected]>