More tests

dotnet · Sep 18, 2024 · 8425e3f · 8425e3f
1 parent eb352eb
commit 8425e3f
Show file tree

Hide file tree

Showing 3 changed files with 605 additions and 61 deletions.
diff --git a/src/Compilers/CSharp/Portable/FlowAnalysis/AbstractFlowPass.cs b/src/Compilers/CSharp/Portable/FlowAnalysis/AbstractFlowPass.cs
@@ -2026,7 +2026,6 @@ protected virtual void PropertySetter(BoundExpression node, BoundExpression rece
             VisitReceiverAfterCall(receiver, setter);
         }
 
-        // PROTOTYPE: Test all uses of this method.
         // returns false if expression is not a property access
         // or if the property has a backing field
         // and accessed in a corresponding constructor

diff --git a/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs b/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
@@ -1074,8 +1074,6 @@ static IEnumerable<Symbol> getAllMembersToBeDefaulted(Symbol requiredMember)
                             }
                         }
 
-                        // PROTOTYPE: Why are we returning the auto-property backing field rather than using the property?
-                        // VisitMemberAccess does the opposite. What are the implications of the inconsistency?
                         // PROTOTYPE: This check for BackingField seems too generous. Shouldn't we also check the appropriate accessors are missing or auto-implemented?
                         static Symbol getFieldSymbolToBeInitialized(Symbol requiredMember)
                             => requiredMember is SourcePropertySymbol { IsAutoProperty: true } prop ? prop.BackingField : requiredMember; // PROTOTYPE: This is the only use of IsAutoProperty.