Specially handle more scenarios for type parameters with 'allows ref …

…struct' constraint (#73111)

src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs

@@ -4025,7 +4025,7 @@ private BoundExpression BindImplicitArrayCreationExpression(ImplicitArrayCreatio
                 bestType = CreateErrorType();
             }
 
-            if (bestType.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Test this for 'allows ref struct' type parameters? 
+            if (bestType.IsRestrictedType())
             {
                 // CS0611: Array elements cannot be of type '{0}'
                 Error(diagnostics, ErrorCode.ERR_ArrayElementCantBeRefAny, node, bestType);
@@ -7516,7 +7516,7 @@ private BoundExpression BindDynamicMemberAccess(
                 for (int i = 0; i < typeArgumentsWithAnnotations.Length; ++i)
                 {
                     var typeArgument = typeArgumentsWithAnnotations[i];
-                    if (typeArgument.Type.IsPointerOrFunctionPointer() || typeArgument.Type.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing? 
+                    if (typeArgument.Type.IsPointerOrFunctionPointer() || typeArgument.Type.IsRestrictedType())
                     {
                         // "The type '{0}' may not be used as a type argument"
                         Error(diagnostics, ErrorCode.ERR_BadTypeArgument, typeArgumentsSyntax[i], typeArgument.Type);
@@ -10892,7 +10892,6 @@ private BoundConditionalAccess BindConditionalAccessExpression(ConditionalAccess
             // - access cannot have unconstrained generic type
             // - access cannot be a pointer
             // - access cannot be a restricted type
-            // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
             if ((!accessType.IsReferenceType && !accessType.IsValueType) || accessType.IsPointerOrFunctionPointer() || accessType.IsRestrictedType())
             {
                 // Result type of the access is void when result value cannot be made nullable.

src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs

@@ -1120,7 +1120,6 @@ private void CheckRestrictedTypeReceiver(BoundExpression expression, CSharpCompi
                             // error CS0029: Cannot implicitly convert type 'A' to 'B'
 
                             // Case 1: receiver is a restricted type, and method called is defined on a parent type
-                            // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
                             if (call.ReceiverOpt.Type.IsRestrictedType() && !call.Method.ContainingType.IsInterface && !TypeSymbol.Equals(call.Method.ContainingType, call.ReceiverOpt.Type, TypeCompareKind.ConsiderEverything2))
                             {
                                 SymbolDistinguisher distinguisher = new SymbolDistinguisher(compilation, call.ReceiverOpt.Type, call.Method.ContainingType);

src/Compilers/CSharp/Portable/Binder/Binder_Operators.cs

@@ -411,7 +411,7 @@ private static bool IsLegalDynamicOperand(BoundExpression operand)
 
             // Pointer types and very special types are not convertible to object.
 
-            return !type.IsPointerOrFunctionPointer() && !type.IsRestrictedType() && !type.IsVoidType(); // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+            return !type.IsPointerOrFunctionPointer() && !type.IsRestrictedType() && !type.IsVoidType();
         }
 
         private BoundExpression BindDynamicBinaryOperator(

src/Compilers/CSharp/Portable/Binder/Binder_Symbols.cs

@@ -643,7 +643,7 @@ private TypeWithAnnotations BindArrayType(
                 // Restricted types cannot be on the heap, but they can be on the stack, so are allowed in a stackalloc
                 if (ShouldCheckConstraints)
                 {
-                    if (type.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+                    if (type.IsRestrictedType())
                     {
                         // CS0611: Array elements cannot be of type '{0}'
                         Error(diagnostics, ErrorCode.ERR_ArrayElementCantBeRefAny, node.ElementType, type.Type);

src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/Conversions.cs

@@ -455,7 +455,7 @@ private static Conversion ToConversion(OverloadResolutionResult<MethodSymbol> re
             }
 
             //cannot capture stack-only types.
-            if (method.RequiresInstanceReceiver && methodGroup.Receiver?.Type?.IsRestrictedType() == true) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+            if (method.RequiresInstanceReceiver && methodGroup.Receiver?.Type?.IsRestrictedType() == true)
             {
                 return Conversion.NoConversion;
             }

src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionsBase.cs

@@ -2829,7 +2829,8 @@ public bool HasImplicitTypeParameterConversion(TypeParameterSymbol source, TypeS
                 return true;
             }
 
-            if ((destination.TypeKind == TypeKind.TypeParameter) &&
+            if (destination is TypeParameterSymbol { AllowByRefLike: false } &&
+                !source.AllowByRefLike &&
                 source.DependsOn((TypeParameterSymbol)destination))
             {
                 return true;
@@ -2848,7 +2849,10 @@ private bool HasImplicitReferenceTypeParameterConversion(TypeParameterSymbol sou
                 return false; // Not a reference conversion.
             }
 
-            // PROTOTYPE(RefStructInterfaces): Check for AllowByRefLike?
+            if (source.AllowByRefLike)
+            {
+                return false;
+            }
 
             // The following implicit conversions exist for a given type parameter T:
             //
@@ -2868,7 +2872,7 @@ private bool HasImplicitReferenceTypeParameterConversion(TypeParameterSymbol sou
             }
 
             // * From T to a type parameter U, provided T depends on U.
-            if ((destination.TypeKind == TypeKind.TypeParameter) &&
+            if (destination is TypeParameterSymbol { AllowByRefLike: false } &&
                 source.DependsOn((TypeParameterSymbol)destination))
             {
                 return true;
@@ -3221,8 +3225,8 @@ private bool HasImplicitBoxingTypeParameterConversion(TypeParameterSymbol source
             }
 
             // SPEC: From T to a type parameter U, provided T depends on U
-            if ((destination.TypeKind == TypeKind.TypeParameter) &&
-                source.DependsOn((TypeParameterSymbol)destination))
+            if (destination is TypeParameterSymbol { AllowByRefLike: false } d &&
+                source.DependsOn(d))
             {
                 return true;
             }
@@ -3280,7 +3284,7 @@ public bool HasBoxingConversion(TypeSymbol source, TypeSymbol destination, ref C
             // There are a couple of exceptions. The very special types ArgIterator, ArgumentHandle and 
             // TypedReference are not boxable: 
 
-            if (source.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+            if (source.IsRestrictedType())
             {
                 return false;
             }
@@ -3476,6 +3480,11 @@ private bool HasExplicitReferenceTypeParameterConversion(TypeSymbol source, Type
             TypeParameterSymbol s = source as TypeParameterSymbol;
             TypeParameterSymbol t = destination as TypeParameterSymbol;
 
+            if (s?.AllowByRefLike == true || t?.AllowByRefLike == true)
+            {
+                return false;
+            }
+
             // SPEC: The following explicit conversions exist for a given type parameter T:
 
             // SPEC: If T is known to be a reference type, the conversions are all classified as explicit reference conversions.
@@ -3523,6 +3532,11 @@ private bool HasUnboxingTypeParameterConversion(TypeSymbol source, TypeSymbol de
             TypeParameterSymbol s = source as TypeParameterSymbol;
             TypeParameterSymbol t = destination as TypeParameterSymbol;
 
+            if (s?.AllowByRefLike == true || t?.AllowByRefLike == true)
+            {
+                return false;
+            }
+
             // SPEC: The following explicit conversions exist for a given type parameter T:
 
             // SPEC: If T is known to be a reference type, the conversions are all classified as explicit reference conversions.
@@ -3753,7 +3767,7 @@ private bool HasUnboxingConversion(TypeSymbol source, TypeSymbol destination, re
             }
 
             // Ref-like types cannot be boxed or unboxed
-            if (destination.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+            if (destination.IsRestrictedType())
             {
                 return false;
             }

src/Compilers/CSharp/Portable/Errors/LazyArrayElementCantBeRefAnyDiagnosticInfo.cs

@@ -31,7 +31,7 @@ protected override DiagnosticInfo GetInstanceWithSeverityCore(DiagnosticSeverity
 
         protected override DiagnosticInfo ResolveInfo()
         {
-            if (_possiblyRestrictedTypeSymbol.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+            if (_possiblyRestrictedTypeSymbol.IsRestrictedType())
             {
                 return new CSDiagnosticInfo(ErrorCode.ERR_ArrayElementCantBeRefAny, _possiblyRestrictedTypeSymbol.Type);
             }

src/Compilers/CSharp/Portable/Lowering/DiagnosticsPass_ExpressionTrees.cs

@@ -375,7 +375,7 @@ public override BoundNode Visit(BoundNode node)
                 !(node is BoundConversion) &&
                 node is BoundExpression expr &&
                 expr.Type is TypeSymbol type &&
-                type.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+                type.IsRestrictedType())
             {
                 Error(ErrorCode.ERR_ExpressionTreeCantContainRefStruct, node, type.Name);
             }
@@ -576,7 +576,7 @@ public override BoundNode VisitLambda(BoundLambda node)
                     {
                         _diagnostics.Add(ErrorCode.ERR_ByRefParameterInExpressionTree, location);
                     }
-                    if (p.TypeWithAnnotations.IsRestrictedType()) // PROTOTYPE(RefStructInterfaces): Is this doing the right thing for 'allows ref struct' type parameters? 
+                    if (p.TypeWithAnnotations.IsRestrictedType())
                     {
                         _diagnostics.Add(ErrorCode.ERR_ExpressionTreeCantContainRefStruct, p.GetFirstLocation(), p.Type.Name);
                     }

src/Compilers/CSharp/Portable/Symbols/AnonymousTypes/SynthesizedSymbols/AnonymousType.TypeParameterSymbol.cs

@@ -95,7 +95,7 @@ public override bool AllowByRefLike
             {
                 get
                 {
-                    return _container.IsDelegateType() && _container.Manager.Compilation.SourceAssembly.RuntimeSupportsByRefLikeGenerics;
+                    return _container.IsDelegateType() && ContainingAssembly.RuntimeSupportsByRefLikeGenerics;
                 }
             }