CA2263: Fix wrong fix for notnull constraints and fix crash on unbound generic types #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because even if notnull constraints are violated, the speculative bind succeeds.
This was due to a bug where the analyzer would continue even if only unbound generic types were used in the typeof operator.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7247 +/- ##
========================================
Coverage 96.47% 96.47%
========================================
Files 1436 1436
Lines 342787 342881 +94
Branches 11289 11292 +3
========================================
+ Hits 330697 330797 +100
+ Misses 9236 9230 -6
Partials 2854 2854 |
buyaa-n
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7245 and fixes #7246.