Do not emit CA1854/CA1864 for nested conditionals #7228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7228 +/- ##
==========================================
+ Coverage 96.47% 96.48% +0.01%
==========================================
Files 1432 1443 +11
Lines 342185 345394 +3209
Branches 11280 11364 +84
==========================================
+ Hits 330107 333244 +3137
- Misses 9227 9271 +44
- Partials 2851 2879 +28 |
buyaa-n
reviewed
Apr 12, 2024
...soft.NetCore.Analyzers/Performance/PreferDictionaryTryMethodsOverContainsKeyGuardAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Apr 12, 2024
...soft.NetCore.Analyzers/Performance/PreferDictionaryTryMethodsOverContainsKeyGuardAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Apr 12, 2024
...soft.NetCore.Analyzers/Performance/PreferDictionaryTryMethodsOverContainsKeyGuardAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected analyzer: PreferDictionaryTryMethodsOverContainsKeyGuardAnalyzer
Affected diagnostic IDs: CA1854 and CA1864
Both diagnostics were emitted for dictionary access guarded by a
ContainsKey()check, even if the dictionary access was in a nested conditional, thus resulting in the fixer changing the semantics of the code.Fixes #7217