[release/8.0.1xx] Update AnalyzerReleases file to reflect new analyzers for .NET8 release #6944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this PR is essential to ensure setting AnalysisLevel to 8 enables the new analyzers added with .NET8.
Codecov Report
@@ Coverage Diff @@
## release/8.0.1xx #6944 +/- ##
================================================
Coverage 96.39% 96.40%
================================================
Files 1402 1402
Lines 331865 331865
Branches 11028 11028
================================================
+ Hits 319916 319921 +5
+ Misses 9188 9182 -6
- Partials 2761 2762 +1 |
carlossanlop
added
the
servicing-consider
|
@jeffhandley @ericstj @artl93 can you please consider this backported fix for release/8.0.1xx? |
jeffhandley
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Looks good. @artl93 we generally treat infrastructure PRs we must merge in order to ship as "Tell Mode."
carlossanlop
added
servicing-approved
and removed
servicing-consider
|
Treating as tell-mode, so marking as |
This was referenced Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6940 to release/8.0.1xx
Customer Impact
Shipped releases in AnalyzerReleases.Shipped.md is used to drive the auto-generation of editorconfig files that ship with the analyzer NuGet package and the .NET SDK and are passed down to the compiler based on the
AnalysisLevelMSBuild property. This PR is needed to ensure that settingAnalysisLevel = 8includes the new analyzers added with this release.Testing
I have verified that locally built Microsoft.CodeAnalysis.NetAnalyzers NuGet package includes these new analyzers added in .NET8 timeframe in the editorconfig files generated for AnalysisLevel 8.
Risk
This should be a pretty low risk fix, something we do at the time of branching every new release branch on this repo for a new .NET release. For example, see #6246 that was checked in for .NET 7 release