Improve handling of indexed array access in flow analysis #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#6616 We now ensure that setting an abstract value for an indexed access entity with any non-constant index clears out the existing value for entities that can overlap the indexed location
mavasani
commented
Jul 17, 2023
| @@ -159,6 +163,46 @@ public PredicateValueKind ApplyPredicatedDataForEntity(AnalysisEntity predicated | |||
|
|
|||
| public void AddTrackedEntities(HashSet<AnalysisEntity> builder) => builder.UnionWith(CoreAnalysisData.Keys); | |||
|
|
|||
| private void ClearOverlappingAnalysisDataForIndexedEntity(AnalysisEntity analysisEntity, TValue value) | |||
There was a problem hiding this comment.
This is the core fix
Youssef1313
reviewed
Jul 17, 2023
| return false; | ||
| } | ||
|
|
||
| // Now perform slow check that compares individual hash code parts sequences. |
There was a problem hiding this comment.
Why are we comparing hash codes?
There was a problem hiding this comment.
@Youssef1313 We were seeing extremely large allocations and CPU stacks for dictionary operations keyed on AnalysisEntity during flow analysis, hence we had switched to using a CacheBasedEquatable approach. It's possible that this is no longer required in the current state of the flow analysis framework, but we would need to invest a few cycles in cleanup and performance measurements on real world code to confirm.
Youssef1313
approved these changes
Jul 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6776 +/- ##
========================================
Coverage 96.34% 96.34%
========================================
Files 1388 1386 -2
Lines 325732 325934 +202
Branches 10735 10722 -13
========================================
+ Hits 313811 314008 +197
- Misses 9210 9215 +5
Partials 2711 2711 |
|
@CollinAlpert I am seeing intermittent test failures for CA1001 in CI after #6741 Test: |
amiru3f
pushed a commit
to amiru3f/roslyn-analyzers
that referenced
this pull request
Jul 26, 2023
Improve handling of indexed array access in flow analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6616
We now ensure that setting an abstract value for an indexed access entity with any non-constant index clears out the existing value for entities that can overlap the indexed location