RS0030: Support banning attribute constructors #6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6772 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 1386 1386
Lines 325659 325736 +77
Branches 10718 10719 +1
=======================================
+ Hits 313732 313812 +80
+ Misses 9215 9213 -2
+ Partials 2712 2711 -1 |
mavasani
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the analyzer for RS0030 decides when attributes should be analyzed. It now also checks the
ContainerName, because theSymbolNamecontains.ctorwhen trying to ban an attribute constructor.Additionally, the symbol check is modified to allow method symbols that are constructors.
AnalyzeAttributesnow also callsVerifySymbolfor attribute constructors.Fixes #6524