Reduce large memory allocations due to public api map construction. #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the profile I'm looking at, 11.4% of large object allocations are due to the ctor creation of the api map. There are two mitigations taken here: 1) Pre-size the dictionary as it's size is known. (I see over 6000 entries in this dictionary when in Roslyn.sln) 2) Defer creation of the api map as it's not needed on many of the code paths where this object is created. For example, just typing inside a method appears to create several instances of this object, but I never see the api map dereferenced during that period.
CyrusNajmabadi
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the profile I'm looking at, 11.4% of large object allocations are due to the ctor creation of the api map. There are two mitigations taken here: