-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit CA1305 when a nullable value type does not specify IFormatProvider #6730
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6730 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 1389 1389
Lines 325104 325128 +24
Branches 10721 10722 +1
=======================================
+ Hits 313159 313189 +30
+ Misses 9234 9228 -6
Partials 2711 2711 |
I think this is good. |
Yes, indeed - #413 (comment) |
Does this mean ToString on |
@CollinAlpert You're awesome! |
Thanks :) |
This PR only focuses on nullable value types which represent numbers. If I should extend this for more value types, please let me know.
I also noticed that the fixer was not implemented yet. Are there requirements for a fixer?
Fixes #6586