Emit CA2251 when comparing string.Compare with 0 using Equals #6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6727 +/- ##
==========================================
- Coverage 96.33% 96.33% -0.01%
==========================================
Files 1393 1393
Lines 325082 325146 +64
Branches 10711 10723 +12
==========================================
+ Hits 313160 313215 +55
- Misses 9217 9219 +2
- Partials 2705 2712 +7 |
mavasani
approved these changes
Jul 3, 2023
|
Thank you @CollinAlpert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false negative where CA2251 is not reported when comparing the result of
string.Comparewith 0 using theint.Equalsmethod.Fixes #6609