Improve performance of spell checking analyzer #6569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToddGrun
reviewed
Apr 4, 2023
| /// Todo, use an actual AdditionalTextValueProvider once it is available: | ||
| /// https://github.com/dotnet/roslyn/issues/67611 | ||
| /// </summary> | ||
| private readonly ConditionalWeakTable<AdditionalText, CodeAnalysisDictionary> _textToDictionary = new(); |
There was a problem hiding this comment.
Correct. Manish preferred non-static CWTs for additional-text mappings.
sharwell
reviewed
Apr 4, 2023
|
|
||
| return dictionary; | ||
|
|
||
| // Local function to avoid unnecessary lambda alloc in mainline case. |
There was a problem hiding this comment.
❔ Wouldn't it only need to alloc the lambda if the lambda references additionalText from the containing scope? In this case, it only seems to reference dictionary from the current scope.
There was a problem hiding this comment.
I'll check the IL, but i believe it will still create a closure.
ToddGrun
reviewed
Apr 4, 2023
| => !projectDictionary.UnrecognizedWords.Contains(word) && projectDictionary.RecognizedWords.Contains(word); | ||
| { | ||
| var unrecognizedWordsContains = dictionaries.Any(static (d, word) => d.ContainsUnrecognizedWord(word), word); | ||
| var recognizedWordsContains = dictionaries.Any(static (d, word) => d.ContainsRecognizedWord(word), word); |
There was a problem hiding this comment.
no. it would def make sense to shortcircuit. i'll do that.
CyrusNajmabadi
commented
Apr 4, 2023
sharwell
reviewed
Apr 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6569 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 1373 1373
Lines 320341 320260 -81
Branches 10309 10296 -13
=======================================
- Hits 308911 308837 -74
+ Misses 8972 8966 -6
+ Partials 2458 2457 -1 |
mavasani
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the enormous amount of dictionary allocations performed on every compilation start: