Reduce allocations more in public api analyzer #6562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6562 +/- ##
==========================================
- Coverage 96.43% 96.43% -0.01%
==========================================
Files 1372 1372
Lines 320264 320265 +1
Branches 10293 10293
==========================================
- Hits 308845 308838 -7
- Misses 8968 8974 +6
- Partials 2451 2453 +2 |
genlu
approved these changes
Mar 31, 2023
mavasani
added a commit
to dotnet/roslyn
that referenced
this pull request
Apr 4, 2023
Includes performance fix made by Cyrus in dotnet/roslyn-analyzers#6562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About .6% when typing in roslyn. Half is the arrays allocated for each line for .TrimStart, the other half are all the dictionary entries created over and over again as we merge apidata files.