Allow [CallerArgumnetExpressionAttribute] after CancellationToken #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tornhoof
commented
Mar 30, 2023
| @@ -440,6 +440,46 @@ public class C | |||
| }"); | |||
| } | |||
|
|
|||
| #if NETCOREAPP3_1_OR_GREATER | |||
There was a problem hiding this comment.
Tests are modelled after the original tests for the other Caller...Attributes
I had to limit the tests to .NET Core 3.1 and higher as .NET 4.7.2 does not contain the attribute.
I find it mildly irritating that the tests are run against netcoreapp3.1 instead of a more recent framework, as 3.1 is out of support.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6558 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 1372 1372
Lines 320278 320319 +41
Branches 10295 10293 -2
=======================================
+ Hits 308848 308896 +48
+ Misses 8975 8968 -7
Partials 2455 2455 |
|
Since the analyzer is already excluding the other CallerXx attributes, makes sense to do it for this one as well. |
Youssef1313
approved these changes
Mar 30, 2023
mavasani
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6557