Only report CA1512 if the specific helper required exists #6549
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were raising the diagnostic if any of the helpers on the type existed even if the specific one required didn't.
lewing
approved these changes
Mar 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6549 +/- ##
=======================================
Coverage ? 96.43%
=======================================
Files ? 1372
Lines ? 320230
Branches ? 10294
=======================================
Hits ? 308806
Misses ? 8971
Partials ? 2453 |
buyaa-n
reviewed
Mar 27, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpers.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were raising the diagnostic if any of the helpers on the type existed even if the specific one required didn't.