Enhance the text for NetAnalyzers upgrade warning #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we report an MSBuild warning when SDK NetAnalyzers version is higher than the referenced NuGet NetAnalyzers version. However, this seems to cause lot of annoyance if we haven't released the newer NuGet at the time newer SDK is released. This PR enhances this text by stating that this warning can be temporarily suppressed by setting '_SkipUpgradeNetAnalyzersNuGetWarning' property to 'true'.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6523 +/- ##
==========================================
+ Coverage 96.15% 96.42% +0.27%
==========================================
Files 1374 1372 -2
Lines 318826 319875 +1049
Branches 10332 10275 -57
==========================================
+ Hits 306553 308440 +1887
+ Misses 9818 8979 -839
- Partials 2455 2456 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we report an MSBuild warning when SDK NetAnalyzers version is higher than the referenced NuGet NetAnalyzers version. However, this seems to cause lot of annoyance if we haven't released the newer NuGet at the time newer SDK is released. This PR enhances this text by stating that this warning can be temporarily suppressed by setting '_SkipUpgradeNetAnalyzersNuGetWarning' property to 'true'.