Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/dotnet/roslyn-analyzers/issues/6479 #6488

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Fix https://github.com/dotnet/roslyn-analyzers/issues/6479 #6488

merged 1 commit into from
Feb 18, 2023

Conversation

geeknoid
Copy link
Member

CA1859 was recommending upgrading types to types that are less visible than the affected symbol, which would lead to broken code. These cases are now explicitly disallowed.

CA1859 was recommending upgrading types to types that are less visible
than the affected symbol, which would lead to broken code. These cases
are now explicitly disallowed.
@geeknoid geeknoid requested a review from a team as a code owner February 14, 2023 21:34
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #6488 (bbb647d) into main (5cd64de) will increase coverage by 0.00%.
The diff coverage is 85.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6488   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files        1371     1371           
  Lines      318980   319011   +31     
  Branches    10265    10269    +4     
=======================================
+ Hits       307513   307568   +55     
+ Misses       9007     8988   -19     
+ Partials     2460     2455    -5     

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n buyaa-n merged commit 913f56f into dotnet:main Feb 18, 2023
@github-actions github-actions bot added this to the vNext milestone Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants