Ban ISourceGenerator implementations #6478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 1371 1371
Lines 318939 318980 +41
Branches 10265 10265
=======================================
+ Hits 307469 307520 +51
+ Misses 9010 9001 -9
+ Partials 2460 2459 -1 |
mavasani
approved these changes
Feb 8, 2023
sharwell
reviewed
Feb 8, 2023
Comment on lines
307
to
309
| VerifyCS.Diagnostic("RS1035").WithSpan(8, 9, 10, 26).WithArguments("GeneratorInitializationContext", ": Non-incremental source generators should not be used, implement IIncrementalGenerator instead"), | ||
| // /0/Test0.cs(14,9): error RS1035: The symbol 'GeneratorExecutionContext' is banned for use by analyzers: Non-incremental source generators should not be used, implement IIncrementalGenerator instead | ||
| VerifyCS.Diagnostic("RS1035").WithSpan(14, 9, 17, 40).WithArguments("GeneratorExecutionContext", ": Non-incremental source generators should not be used, implement IIncrementalGenerator instead"), |
There was a problem hiding this comment.
💡 The WithLocation API makes it easier to see where the diagnostic is appearing relative to source code.
Suggested change
| VerifyCS.Diagnostic("RS1035").WithSpan(8, 9, 10, 26).WithArguments("GeneratorInitializationContext", ": Non-incremental source generators should not be used, implement IIncrementalGenerator instead"), | |
| // /0/Test0.cs(14,9): error RS1035: The symbol 'GeneratorExecutionContext' is banned for use by analyzers: Non-incremental source generators should not be used, implement IIncrementalGenerator instead | |
| VerifyCS.Diagnostic("RS1035").WithSpan(14, 9, 17, 40).WithArguments("GeneratorExecutionContext", ": Non-incremental source generators should not be used, implement IIncrementalGenerator instead"), | |
| VerifyCS.Diagnostic("RS1035").WithLocation(0).WithArguments("GeneratorInitializationContext", ": Non-incremental source generators should not be used, implement IIncrementalGenerator instead"), | |
| // /0/Test0.cs(14,9): error RS1035: The symbol 'GeneratorExecutionContext' is banned for use by analyzers: Non-incremental source generators should not be used, implement IIncrementalGenerator instead | |
| VerifyCS.Diagnostic("RS1035").WithLocation(1).WithArguments("GeneratorExecutionContext", ": Non-incremental source generators should not be used, implement IIncrementalGenerator instead"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/roslyn#65106. Not banning
ISourceGeneratordirectly as that seems unsupported by the banned API analyzer.