-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't emit CA1704 for interface implementations #6473
Conversation
removed unnecessary added blank line
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6473 +/- ##
========================================
Coverage 96.40% 96.41%
========================================
Files 1371 1371
Lines 318939 319253 +314
Branches 10265 10278 +13
========================================
+ Hits 307480 307795 +315
+ Misses 9002 9000 -2
- Partials 2457 2458 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for explicit interface implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Applesauce314. This LGTM 🎉
Done |
…match the base definition name
remove blank lines
This comment was marked as outdated.
This comment was marked as outdated.
Final state: |
updates CA1704 as described in #6472.
if the method a parameter is part of is an interface implementation or an override, CA1704 is not emitted. This prevents warnings/errors that cannot be fixed if CA1725 is also active.