Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report blocking Thread.Sleep calls in async methods #6359

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Report blocking Thread.Sleep calls in async methods #6359

merged 2 commits into from
Jan 5, 2023

Conversation

Youssef1313
Copy link
Member

Fixes #6268

@Youssef1313 Youssef1313 marked this pull request as ready for review December 15, 2022 15:00
@Youssef1313 Youssef1313 requested a review from a team as a code owner December 15, 2022 15:00
@codecov
Copy link

codecov bot commented Dec 15, 2022 •
edited
Loading

Codecov Report

Merging #6359 (1b96653) into main (37c910d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6359      +/-   ##
==========================================
+ Coverage   96.08%   96.13%   +0.04%     
==========================================
  Files        1362     1361       -1     
  Lines      315490   316628    +1138     
  Branches    10187    10202      +15     
==========================================
+ Hits       303137   304384    +1247     
+ Misses       9920     9811     -109     
  Partials     2433     2433

stephentoub
stephentoub approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one-line src change and the test LGTM.

@Youssef1313 Youssef1313 mentioned this pull request Jan 4, 2023
Merged
@stephentoub stephentoub merged commit 14e2ece into dotnet:main Jan 5, 2023
@stephentoub
Copy link
Member

Thanks

@github-actions github-actions bot added this to the vNext milestone Jan 5, 2023
@Youssef1313 Youssef1313 deleted the ca1849 branch January 5, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

CA1849 ("Call async methods when in an async method") should flag Thread.Sleep
2 participants
@Youssef1313 @stephentoub