Adding a setting to .editorconfig to enforce formatting #11236
Conversation
| where !keyValuePair.Key.TranslateTo(visibleSpan.Snapshot, SpanTrackingMode.EdgeExclusive).IntersectsWith(visibleSpan) | ||
| select keyValuePair.Key; |
There was a problem hiding this comment.
What does this end up looking like if we format it? I can't see anything obviously weird here
There was a problem hiding this comment.
that looks like a formatting bug...
what if we change it to
var toRemove =
from keyValuePari
in _adornmentCache
where ....
select ...There was a problem hiding this comment.
... unless I manually indent in, then formatter is happy with this
There was a problem hiding this comment.
Looking at the docs at https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/from-clause, recommendation seems to be to have in on the same line as from, after which formatting basically makes sense (though formatting in the first two examples in the same docs is still getting "corrected" by C# formatter). I made the change to make the formatter happy.
There was a problem hiding this comment.
ahh, yep, that's what it is. I didn't see it, but I always have put in on the same line as from.
There was a problem hiding this comment.
ahh, yep, that's what it is. I didn't see it, but I always have put
inon the same line asfrom.
FWIW, that's pretty uncommon. Every single LINQ sample ever produced by Microsoft had from and in on the same line because that's how we expected query expressions to be formatted. I've personally never seen in on a separate line until now. 😄
There was a problem hiding this comment.
FWIW, that's pretty uncommon
I think you misread what I wrote :) We're in vehement agreement about from and in being on the same line :)
I've personally never seen in on a separate line until now
Me neither, that's why I missed it when I wrote "I can't see anything obviously weird here" above.
| @@ -8,9 +8,11 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer.Hosting; | |||
| [Flags] | |||
| internal enum FormattingFlags | |||
| { | |||
| #pragma warning disable format | |||
There was a problem hiding this comment.
any particular reason? What does it want to format to?
There was a problem hiding this comment.
It wants to remove all spaces but 1. I am not seeing an option to allow multiple spaces in Flags. I mean we don't have to have them, just looks nicer :) This is what it would've looked like
There was a problem hiding this comment.
Personally, I'm totally fine with this not being lined up perfectly. I really don't like suppressions, they're uglier than jagged formatting :D
There was a problem hiding this comment.
That's a fair point. I removed suppressions and extra spaces. I think all suppressions are gone now.
There was a problem hiding this comment.
IMO, if we want this setting in .editorconfig, we should agree to never suppress it.
| where !keyValuePair.Key.TranslateTo(visibleSpan.Snapshot, SpanTrackingMode.EdgeExclusive).IntersectsWith(visibleSpan) | ||
| select keyValuePair.Key; |
There was a problem hiding this comment.
that looks like a formatting bug...
what if we change it to
var toRemove =
from keyValuePari
in _adornmentCache
where ....
select ...
Summary of the changes
Fixes: https://github.com/orgs/dotnet/projects/197?pane=issue&itemId=88054220