Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing html snippet completion and integration tests #11172

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

alexgav
Copy link
Contributor

@alexgav alexgav commented Nov 6, 2024

HTML snippet completions were being included when they shouldn't have been

### Summary of the changes

  • Include HTML snippet completions only when they request flag indicates they should be
  • Also added a cohosting test, though this was not broken in cohosting

Fixes:

  • Integration tests
  • Snippets included when they shouldn't be (e.g. in a start tag)

HTML snippet completions were being included when they shouldn't have been
@alexgav alexgav requested a review from a team as a code owner November 6, 2024 18:20
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@alexgav alexgav merged commit c6c3190 into main Nov 6, 2024
17 checks passed
@alexgav alexgav deleted the dev/alexgav/FixHtmlSnippetCompletion branch November 6, 2024 21:35
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 6, 2024
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants