Improvements for Assumed.Unreachable(...) #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses two issues that may help with diagnosis: 1. `Assumed.Unreachable(...)`captures the `[CallerFilePath]` and `[CallerLineNumber]` but didn't do anything with them. Now, those values are appended to the exception message. 2. Two `Assumed.Unreachable(...)` overloads have been added to allow a custom exception message to be provided that can be used to add more detail about a failure.
ryzngard
approved these changes
Nov 5, 2024
chsienki
approved these changes
Nov 5, 2024
davidwengier
approved these changes
Nov 5, 2024
333fred
approved these changes
Nov 5, 2024
|
Thanks all! |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up to #11144 (comment) that addresses two issues that may help with diagnosis:
Assumed.Unreachable(...)captures the[CallerFilePath]and[CallerLineNumber]but didn't do anything with them. Now, those values are appended to the exception message.Assumed.Unreachable(...)overloads have been added to allow a custom exception message to be provided that can be used to add more detail about a failure.