Replace IProjectCollectionResolver with ISolutionQueryOperations #10943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IProjectCollectionResolver was intended to be passed into services that need to enumerate project snapshots to allow them to be used in co-hosting. Instead of encapsulating the state it operates on, a "context" IDocumentSnapshot was passed into IProjectCollectionResolver.EnumerateProjects(...). In co-hosting, the "context" IDocumentSnapshot would be used to extract the Roslyn Solution, while the language server would ignore the parameter entirely. This change introduces IProjectQueryService to replace IProjectCollectionResolver. In the language server, it wraps IProjectSnapshotManager. In co-hosting, a new instance of the service is created for any service call and wraps the Roslyn Solution snapshot.
davidwengier
approved these changes
Oct 1, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/GoToDefinition/RemoteGoToDefinitionService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/ProjectQueryServiceFactory.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RazorBrokeredServiceBase.cs
Outdated
Show resolved
Hide resolved
This is a significant change for co-hosting that redesigns how remote snapshots work. - Introduce RemoteSolutionSnapshot to wrap a solution and a collection of RemoteProjectSnapshots. - Rework RemoteProjectSnapshot to simply wrap a document and a collection of RemoteDocumentSnapshots. - Introduce RemoteSnapshotManager that can retrieve a snapshot for a Solution, Project, or TextDocument. - Enforce that RemoteDocumentSnapshots can *only* be created from razor or cshtml documents. - Reduce to a single CWT that maps Solution -> RemoteSolutionSnapshot. - Add RemoteDocumentContext.ProjectQueryService convenience property.
This has gone through enough churn, that I've clicked refresh on your review. Thanks very much for your feedback! Please take another look when you have time! |
davidwengier
approved these changes
Oct 2, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/RemoteDocumentContext.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/ProjectExtensions.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
changed the title
davidwengier
approved these changes
Oct 2, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IProjectCollectionResolverwas intended to be passed into services that need to enumerate project snapshots to allow them to be used in co-hosting. Instead of encapsulating the state, it operates on a "context"IDocumentSnapshotpassed intoIProjectCollectionResolver.EnumerateProjects(...). In co-hosting, this "context"IDocumentSnapshotwould be used to extract the Roslyn Solution for project enumeration, while the language server would ignore the parameter entirely.This change introduces
ISolutionQueryOperationsand replacesIProjectCollectionResolver. A key difference fromIProjectCollectionResolveris thatISolutionQueryOperationsis not available via DI or the MEF composition. Instead of importing a singleton interface in the language server, anISolutionQueryOperationscan be retrieved by callingIProjectSnapshotManager.GetSolutionQueryOperations(). In co-hosting, there is a newRemoteSolutionSnapshotclass that wraps a Roslyn Solution and implementsISolutionQueryOperations. This ensures that co-hosting endpoints that don't have immediate access to the target document (such ascompletionitem/resolve) can still walk projects.