Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohosting test infrastructure v2 #10612

Merged
merged 8 commits into from
Jul 12, 2024
Merged

Cohosting test infrastructure v2 #10612

merged 8 commits into from
Jul 12, 2024

Conversation

davidwengier
Copy link
Member

@davidwengier davidwengier commented Jul 11, 2024 •
edited
Loading

Part of #9519 and #10603

I did a bad. Well a couple of bads.

A few things this PR does/issues we (I 😛) had:

  • All of our OOP services are disposable, but the interfaces and type constraints didn't reflect that, so I missed disposing them in tests. This fixes that by disposing the services, but also:
  • We were using service factories to create our services, which meant some service broker types were involved that needed to be disposed. Now we create our services directly and no service broker types are needed
  • Logging in OOP uses a single TraceSource for all services, which is arguably dodgy but a limitation of our MEF based logger factory. In tests however, reusing the test output helper is a bad thing, so I've just removed the logging for tests for now.

@davidwengier davidwengier changed the title Logging Fix cohosting tests Jul 12, 2024
@davidwengier davidwengier marked this pull request as ready for review July 12, 2024 02:40
@davidwengier davidwengier requested a review from a team as a code owner July 12, 2024 02:40
@davidwengier davidwengier changed the title Fix cohosting tests Cohosting test infrastructure v2 Jul 12, 2024
@davidwengier davidwengier enabled auto-merge July 12, 2024 06:08
@davidwengier
Copy link
Member Author

Setting auto merge in case someone approves while I'm asleep, since the test failures are reasonably blocking

alexgav
alexgav approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit 24c99ef into dotnet:main Jul 12, 2024
12 checks passed
@davidwengier davidwengier deleted the FilePathNormalizerTestFailure branch July 12, 2024 07:12
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 12, 2024
This was referenced Jul 16, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 Preview 1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgav alexgav alexgav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.12 Preview 1
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwengier @alexgav @RikkiGibson