Flesh out PooledArrayBuilder<T> a bit
#10606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Jul 10, 2024
davidwengier
approved these changes
Jul 10, 2024
333fred
reviewed
Jul 11, 2024
src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/PooledObjects/PooledArrayBuilder`1.cs
Show resolved
Hide resolved
This change adds `First()`, `FirstOrDefault()`, `Last()`, `LastOrDefault()`, Single()`, and `SingleOrDefault()` extension methods for `IReadOnlyList<T>` along with a comprehensive set of overloads. In addition, I've added an `AsEnumerable()` that returns a struct that wraps `IReadOnlyList<T>` with a struct enumerator. This makes it easy to foreach over an `IReadOnlyList<T>` without allocating.
|
@333fred: This is ready for another look. |
333fred
approved these changes
Jul 12, 2024
chsienki
approved these changes
Jul 15, 2024
333fred
reviewed
Jul 15, 2024
| @@ -880,30 +880,20 @@ public static T SingleOrDefault<T>(this IReadOnlyList<T> list, Func<T, bool> pre | |||
|
|
|||
| public static Enumerable<T> AsEnumerable<T>(this IReadOnlyList<T> list) => new(list); | |||
|
|
|||
| public readonly struct Enumerable<T>(IReadOnlyList<T> list) : IEnumerable<T> | |||
| public readonly ref struct Enumerable<T>(IReadOnlyList<T> list) | |||
There was a problem hiding this comment.
What's the benefit of changing these to ref struct types?
There was a problem hiding this comment.
It came out of @jjonescz's comment on a different PR here. Essentially, there's no reason to ever want to box these types. So, it's just a little extra protection. I don't think there's really much value in this change, but it was simple enough. It's just a little extra protection. After all, if the user wants to pass an IReadOnlyList<T> to an IEnumerable<T>, they can just pass it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
First,FirstOrDefault,Last,LastOrDefault,Single,SingleOrDefault,AnyandAllLINQ-style APIs toPooledArrayBuilder<T>.