Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix razor/namedPipe params to use STJ. Also rename the endpoint #10604

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix razor/namedPipe params to use STJ. Also rename the endpoint #10604

merged 1 commit into from
Jul 10, 2024

Conversation

ryzngard
Copy link
Contributor

No description provided.

@ryzngard ryzngard requested a review from a team as a code owner July 10, 2024 07:18
DustinCampbell
DustinCampbell approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes the LSP communication that provides the pipe name use STJ, right?. It doesn't actually make the named pipe itself use STJ. I was a bit confused by the title.

@ryzngard
Copy link
Contributor Author

This just makes the LSP communication that provides the pipe name use STJ, right?. It doesn't actually make the named pipe itself use STJ. I was a bit confused by the title.

Correct. Let me clarify the title

@ryzngard ryzngard changed the title Fix namedpipe to use STJ. Also rename the endpoint Fix razor/namedPipe params to use STJ. Also rename the endpoint Jul 10, 2024
@ryzngard ryzngard enabled auto-merge (squash) July 10, 2024 20:40
@ryzngard ryzngard merged commit fda387e into dotnet:main Jul 10, 2024
12 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 10, 2024
@ryzngard ryzngard deleted the stj_fix branch July 10, 2024 20:52
This was referenced Jul 16, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 Preview 1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.12 Preview 1
Development

Successfully merging this pull request may close these issues.
4 participants
@ryzngard @DustinCampbell @davidwengier @RikkiGibson