Tweak RazorConfigurationFormatter to account for serialization format change #10157
Conversation
… change The recent FUSE changes updated the RazorConfigurationFormatter to write serialize/deserialize a new boolean. However, `SerializationFormat.Version` for MessagePack wasn't updated, so it just fails during deserialization when older project.razor.bin files are initially read off disk. This tweaks the deserializer to be more forgiving and handle the case that the boolean isn't present. A similar change is not needed in the JSON serialization because that deserializer was written to be a bit more forgiving and the JSON `SerializationFormat.Version` was updated.
DustinCampbell
force-pushed
the
fix-msgpack-formatter
branch
from
b626b86 to
d45f5a4
Compare
|
Do we need to bump the version number? Thanks for fixing this, sorry I missed it! I didn't notice I only bumped the json version not the messagepack. Also, is there a way we can catch this in the future? |
I don't think so. The idea was to write this in such a way that the version number shouldn't need bumping. Bumping the version number has the consequence of needing to insert a new Razor for VS Code, so I try to avoid doing that unless absolutely necessary. Looking at the JSON serializer change, that actually probably didn't need a version number change, since the change used
Honestly, it's kind of hard to catch. Nothing simple comes to mind. 😦 |
There was a problem hiding this comment.
Sorry, I missed that the version bump was in the wrong spot.
I don't love having the two versions be different, and the two deserialization classes be different, but at the same time its probably a little mean to make Andrew do another dual insertion after he already did one, and it turned out to not be necessary 😁
The recent FUSE changes updated the
RazorConfigurationFormatterto write serialize/deserialize a new boolean. However,SerializationFormat.Versionfor MessagePack wasn't updated, so it just fails during deserialization when olderproject.razor.binfiles are initially read off disk. This tweaks the deserializer to be more forgiving and handle the case that the boolean isn't present.A similar change is not needed in the JSON serialization because that deserializer was written to be a bit more forgiving and the JSON
SerializationFormat.Versionwas updated.I ran into this when opening an old clone of OrchardCore that I'd opened previously, and started hitting exceptions during message pack deserialization.