Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow editing contentfiles from packages #2141

Closed
srivatsn opened this issue May 8, 2017 · 7 comments · Fixed by #6480
Closed

Disallow editing contentfiles from packages #2141

srivatsn opened this issue May 8, 2017 · 7 comments · Fixed by #6480
Assignees
@davkean
Labels
Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Milestone
16.8

Comments

@srivatsn
Copy link
Contributor

srivatsn commented May 8, 2017

Content files from nuget package simply show up in the tree as editable items. #604 tracks coming up with a proper editing experience by cloning the file but until then we should just mark them as readonly so that users don't accidentally change the packages.
@srivatsn srivatsn added the Bug label May 8, 2017
@srivatsn srivatsn modified the milestones: 15.3, 15.6 May 8, 2017
@Pilchie Pilchie modified the milestones: 15.5, 15.6 Oct 17, 2017
@Pilchie Pilchie added the Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. label Dec 20, 2017
@Pilchie Pilchie modified the milestones: 15.6, Unknown Dec 20, 2017
@nkolev92 nkolev92 mentioned this issue Apr 6, 2018
Open
@bording
Copy link
Contributor

bording commented Nov 14, 2018

Is there any chance of this being addressed in the VS 2019 timeframe? This is a problem that should definitely be fixed!

@jjmew jjmew added the Triage-Approved Reviewed and prioritized label Jan 14, 2019
@rrelyea rrelyea mentioned this issue Nov 1, 2019
Open
@bording bording mentioned this issue Apr 7, 2020
Closed
@drewnoakes
Copy link
Member

When addressing this, see if we can get invocation to open content file items in the dependencies tree to open the file, also non-editable.

@Barsonax Barsonax mentioned this issue Jun 15, 2020
Open
@Barsonax
Copy link

Any chance this is gonna get fixed soon? This seems to be a pretty serious bug as it makes it possible to edit a shared package.

According to the documentation contenfiles should be readonly so tooling should respect that!

@Barsonax Barsonax mentioned this issue Jun 15, 2020
Closed
@jjmew jjmew modified the milestones: Backlog, 16.8 Jun 16, 2020
@jjmew
Copy link
Contributor

jjmew commented Jun 16, 2020

@ocallesp This is came up because #6290 we believe this is important as we shouldn't allow those files to be edited.

@ocallesp
Copy link
Contributor

ocallesp commented Aug 9, 2020

@drewnoakes I created a simple Console NetCore project and added the nuget package AdamsLair.Duality.Samples.Tilemaps. There are some files under Content Files, but cannot open or edit them.
Was editing already disabled ? It seems that this issue was fixed, but should be able to open the res files ?

image

@drewnoakes
Copy link
Member

@ocallesp these nodes were never wired up for interaction beyond the browse object. We may do that in future.

This bug relates to the equivalent items within the "Data" folder at the bottom of your screenshot.

davkean added a commit to davkean/project-system that referenced this issue Aug 10, 2020
@davkean
Mark package content items as "user read-only"
8c1ce1f 
Fixes: dotnet#2141

This marks package content items as user read-only, which causes them to be opened read-only in the editor.
davkean added a commit to davkean/project-system that referenced this issue Aug 10, 2020
@davkean
Mark package content items as "user read-only"
ca3df43 
Fixes: dotnet#2141

This marks package content items as user read-only, which causes them to be opened read-only in the editor.

This depends on https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/266425.
@davkean davkean mentioned this issue Aug 10, 2020
Merged
@davkean
Copy link
Member

davkean commented Aug 10, 2020

PR: #6480 and https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/266425 (Microsofties only).

@davkean davkean assigned davkean and unassigned ocallesp and tmeschter Aug 10, 2020
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Aug 11, 2020
@nkolev92 nkolev92 mentioned this issue Jan 4, 2021
Closed
@drewnoakes drewnoakes removed the Bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkean davkean

Labels
Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
16.8
Development

Successfully merging a pull request may close this issue.

Mark package content items as "user read-only" davkean/project-system
10 participants
@srivatsn @Pilchie @drewnoakes @ocallesp @bording @davkean @tannergooding @tmeschter @jjmew @Barsonax