Fix nullable warnings

dotnet · Aug 7, 2020 · 484014c · 484014c
1 parent 01ca687
commit 484014c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/src/Microsoft.VisualStudio.Editors/GlobalSuppressions.vb b/src/Microsoft.VisualStudio.Editors/GlobalSuppressions.vb
@@ -1333,6 +1333,8 @@ Imports System.Diagnostics.CodeAnalysis
 <Assembly: SuppressMessage("Naming", "CA1713:Events should not have 'Before' or 'After' prefix", Justification:="<Pending>", Scope:="member", Target:="~E:Microsoft.VisualStudio.Editors.MyExtensibility.TrackProjectDocumentsEventsHelper.AfterRemoveFiles")>
 <Assembly: SuppressMessage("Naming", "CA1713:Events should not have 'Before' or 'After' prefix", Justification:="<Pending>", Scope:="member", Target:="~E:Microsoft.VisualStudio.Editors.MyExtensibility.TrackProjectDocumentsEventsHelper.AfterRenameDirectories")>
 <Assembly: SuppressMessage("Naming", "CA1713:Events should not have 'Before' or 'After' prefix", Justification:="<Pending>", Scope:="member", Target:="~E:Microsoft.VisualStudio.Editors.MyExtensibility.TrackProjectDocumentsEventsHelper.AfterRenameFiles")>
+<Assembly: SuppressMessage("Usage", "VSTHRD100:Avoid async void methods", Scope:="member", Target:="~M:Microsoft.VisualStudio.Editors.XmlIntellisense.XmlIntellisenseSchemas.CompileCallBack(Microsoft.VisualStudio.Editors.XmlIntellisense.XmlIntellisenseSchemasData)")>
 
 ' Bugs
 <Assembly: SuppressMessage("Style", "IDE0070:Use 'System.HashCode'", Justification:="https://github.com/dotnet/roslyn/issues/45995", Scope:="member", Target:="~M:Microsoft.VisualStudio.Editors.PropertyPages.WPF.ApplicationPropPageVBWPF.StartupObject.GetHashCode~System.Int32")>
+
diff --git a/...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/Properties/StartupObjectsEnumProvider.cs b/...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/Properties/StartupObjectsEnumProvider.cs
@@ -54,7 +54,7 @@ public StartupObjectsEnumGenerator(Workspace workspace, UnconfiguredProject proj
 
         public async Task<ICollection<IEnumValue>> GetListedValuesAsync()
         {
-            Project project = _workspace.CurrentSolution.Projects.First(p => PathHelper.IsSamePath(p.FilePath, _unconfiguredProject.FullPath));
+            Project project = _workspace.CurrentSolution.Projects.First(p => PathHelper.IsSamePath(p.FilePath!, _unconfiguredProject.FullPath));
             Compilation? compilation = await project.GetCompilationAsync();
 
             IEntryPointFinderService? entryPointFinderService = project.LanguageServices.GetService<IEntryPointFinderService>();

diff --git a/...ProjectSystem/Properties/InterceptedProjectProperties/ApplicationManifestValueProvider.cs b/...ProjectSystem/Properties/InterceptedProjectProperties/ApplicationManifestValueProvider.cs
@@ -80,7 +80,7 @@ public override async Task<string> OnGetEvaluatedPropertyValueAsync(string prope
                 await defaultProperties.DeletePropertyAsync(NoManifestMSBuildProperty);
                 // If we can make the path relative to the project folder do so. Otherwise just use the given path.
                 if (Path.IsPathRooted(unevaluatedPropertyValue) &&
-                    PathHelper.TryMakeRelativeToProjectDirectory(_unconfiguredProject, unevaluatedPropertyValue, out string relativePath))
+                    PathHelper.TryMakeRelativeToProjectDirectory(_unconfiguredProject, unevaluatedPropertyValue, out string? relativePath))
                 {
                     returnValue = relativePath;
                 }

diff --git a/...nterceptedProjectProperties/SigningPropertyPage/AssemblyOriginatorKeyFileValueProvider.cs b/...nterceptedProjectProperties/SigningPropertyPage/AssemblyOriginatorKeyFileValueProvider.cs
@@ -25,7 +25,7 @@ public AssemblyOriginatorKeyFileValueProvider(UnconfiguredProject project)
             IReadOnlyDictionary<string, string>? dimensionalConditions = null)
         {
             if (Path.IsPathRooted(unevaluatedPropertyValue) &&
-                _unconfiguredProject.TryMakeRelativeToProjectDirectory(unevaluatedPropertyValue, out string relativePath))
+                _unconfiguredProject.TryMakeRelativeToProjectDirectory(unevaluatedPropertyValue, out string? relativePath))
             {
                 unevaluatedPropertyValue = relativePath;
             }

diff --git a/...Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/UpToDate/BuildUpToDateCheck.cs b/...Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/UpToDate/BuildUpToDateCheck.cs
@@ -439,7 +439,7 @@ private bool CheckMarkers(Log log, in TimestampCache timestampCache, State state
             // here if the project actually produced a marker and we only check it against references that
             // actually produced a marker.
 
-            if (string.IsNullOrWhiteSpace(state.CopyUpToDateMarkerItem) || !state.CopyReferenceInputs.Any())
+            if (Strings.IsNullOrWhiteSpace(state.CopyUpToDateMarkerItem) || !state.CopyReferenceInputs.Any())
             {
                 return true;
             }