Do not print-out version info in terminal logger

[JanKrivanek]

Based on another @rainersigwald feedback to the msbuild talk

Context

The versioning info feels unnecessary in terminal logger mode (TL logs are not meant for post-hoc investigation).

Changes made

Frontloaded the TL check, so that we can add the TL enablement status to the decision about version message need

Shortcomings

In case of TL enabled by env or params, but disabled by response file, we'll still NOT disable the version message - as the message flushing happens before processing response files. This was chosen as it greatly simplifies the change (and it can be minimal risk change), as console logs are not anyways the main source of investigation data

[f-alizada]

Looks good ! :)

[ladipro]

The version is still printed when -tl is added via msbuild.rsp. Repro:

1. echo "-tl" > msbuild.rsp
2. msbuild

Also, do you think this could be covered with a test? The command line processing logic is quite complex so it would be nice to have something in place to prevent regressions.

[JanKrivanek]

The version is still printed when -tl is added via msbuild.rsp. Repro:

1. echo "-tl" > msbuild.rsp
2. msbuild

Also, do you think this could be covered with a test? The command line processing logic is quite complex so it would be nice to have something in place to prevent regressions.

Disregarding the responce file was choosen to simplify the change (so that message flushing can be kept at place before processing the response file). I put this into PR description - but that might not have been enough - let me add an explicit info into the comment in the code.
I wouldn't complicate the logic now without feedback. Unfortunately we do not have concrete data - but I'd expect interactive CLI interactions to prefere dotnet build, while msbuild.exe rather being used in noninteractive scenarios.

Or would you prefer the response file scenario to be fully respected as well?

[ladipro]

Sorry, I should have read the description 🤦‍♂️ I agree it's ok to not support it.

[JanKrivanek]

NP - comment in code is very much needed.

And let me add the test as well (@f-alizada will be happy as I was resisting his request when he raised it previously here and I must admit it was and is a very reasonable ask)

[JanKrivanek]

Comment and test cases added