CA1200: Avoid using cref tags with a prefix #7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elachlan
commented
Jan 2, 2022
sharwell
reviewed
Jan 3, 2022
Co-authored-by: Sam Harwell <[email protected]>
Co-authored-by: Sam Harwell <[email protected]>
Co-authored-by: Sam Harwell <[email protected]>
sharwell
approved these changes
Jan 3, 2022
Forgind
approved these changes
Jan 3, 2022
elachlan
commented
Jan 7, 2022
elachlan
commented
Jan 7, 2022
| @@ -434,7 +434,7 @@ public static ProjectCollection GlobalProjectCollection | |||
| /// This is the Windows file version (specifically the value of the FileVersion | |||
| /// resource), not necessarily the assembly version. | |||
| /// If you want the assembly version, use Constants.AssemblyVersion. | |||
| /// This is not the <see cref="P:Microsoft.Build.BuildEngine.ToolsetCollection.ToolsVersions*">ToolsetCollection.ToolsVersions</see>. | |||
| /// This is not a <see cref="Toolset"/>. | |||
There was a problem hiding this comment.
I think this is the modern equivalent:
Suggested change
| /// This is not a <see cref="Toolset"/>. | |
| /// This is not the <see cref="Toolset.ToolsVersion"/>. |
Co-authored-by: Rainer Sigwald <[email protected]>
Forgind
approved these changes
Jan 10, 2022
|
Is there anything waiting to be done in this? |
rainersigwald
approved these changes
Feb 28, 2022
rainersigwald
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7174
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/CA1200