CA2208 Instantiate argument exceptions correctly

[elachlan]

Relates to #7174
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/CA2208

[elachlan]

Build is failing on dependency microsoft.codeanalysis.collections:

/home/vsts/.nuget/packages/microsoft.codeanalysis.collections/4.0.0-4.21379.20/contentFiles/cs/netstandard2.0/ImmutableSegmentedList`1.cs(346,23): error CA2208: (NETCORE_ENGINEERING_TELEMETRY=Build) Call the ArgumentException constructor that contains a message and/or paramName parameter
/home/vsts/.nuget/packages/microsoft.codeanalysis.collections/4.0.0-4.21379.20/contentFiles/cs/netstandard2.0/ImmutableSegmentedList`1+ValueBuilder.cs(249,27): error CA2208: (NETCORE_ENGINEERING_TELEMETRY=Build) Call the ArgumentException constructor that contains a message and/or paramName parameter

https://github.com/dotnet/roslyn/blob/24ef0f30f29298be003d2d7d5de29f9906c37611/src/Dependencies/Collections/ImmutableSegmentedList%601.cs#L346

https://github.com/dotnet/roslyn/blob/24ef0f30f29298be003d2d7d5de29f9906c37611/src/Dependencies/Collections/ImmutableSegmentedList%601%2BValueBuilder.cs#L249

[elachlan]

Related Roslyn issue:
dotnet/roslyn#45286

[Forgind]

So we're waiting for that issue to be resolved? That looks outside the MSBuild layer.

[elachlan]

Yes, I am not sure how to tell the analyzer not to analyze code like this. So I am attempting to fix the upstream code.

[Youssef1313]

@elachlan Those errors should be suppressible via editorconfig per dotnet/roslyn#55992, probably something like:

[**/microsoft.codeanalysis.collections/**/*.cs]
# CA2208: Instantiate argument exceptions correctly
dotnet_diagnostic.CA2208.severity = none

If it doesn't work (I haven't tested), then dotnet/roslyn#55992 should probably re-considered.

FYI @jaredpar

[elachlan]

.editorconfig didn't work. But I don't think we are using IncludeContentInPack.

[Youssef1313]

@elachlan I can't think of how Microsoft.CodeAnalysis.Collections contents are seen by the compiler without, somehow, IncludeContentInPack being set (on Roslyn side I mean).

Since you can confirm that .editorconfig doesn't work. I'd like @jaredpar to re-consider something for dotnet/roslyn#55992

[elachlan]

See the commit adding it here:
f1cd160

[Youssef1313]

@elachlan I'm referring to roslyn side, the package itself has its source code included in pack:

That's why I think dotnet/roslyn#55992 is relevant.

[elachlan]

@sharwell in dotnet/roslyn#55992 it was pointed out that globalconfig defined analyzers apply to source code supplied by nuget packages as well. Where as .editorconfig files do not apply analyzers to against the packages.

This means I will unfortunately need to move back to using .editorconfigs. Unless you know of a better way?