Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildcheck - ProjectImported OM fixes #11049

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Buildcheck - ProjectImported OM fixes #11049

merged 5 commits into from
Dec 9, 2024

Conversation

JanKrivanek
Copy link
Member

Fixes #10960, #10935

Context

  • ProjectImported OM wasn't properly propagated if binlog wasn't specified
  • ProjectImported OM should only be handled in single threaded context of main node logger

Testing

Preexisting tests

YuliiaKovalova
YuliiaKovalova approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😊

@JanKrivanek JanKrivanek enabled auto-merge (squash) December 5, 2024 20:39
@JanKrivanek JanKrivanek merged commit f020599 into main Dec 9, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the buildcheck/importsargs-fixes branch December 9, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maridematte maridematte maridematte approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

@SimaTian SimaTian Awaiting requested review from SimaTian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProjectImported OM should only exist in logger thread context
4 participants
@JanKrivanek @SimaTian @maridematte @YuliiaKovalova