Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #11032

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: fc4faec0-9ee6-43b9-bc7a-08da8607f4c7
  • Build: 20241122.2
  • Date Produced: November 22, 2024 6:31:15 PM UTC
  • Commit: b41381d5cd633471265e9cd72e933a7048e03062
  • Branch: refs/heads/release/9.0
  • Updates to .NET SDKs:
    • Updates tools.dotnet to 9.0.100

…122.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24562.13 -> To Version 9.0.0-beta.24572.2
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner November 25, 2024 13:48
@GangWang01 GangWang01 force-pushed the darc-main-ae7e245f-cd32-43c5-bf7e-da57c88bdd50 branch from 883f9dc to 85e8af5 Compare November 27, 2024 06:50
@GangWang01
Copy link
Member

This updates dotnet to 9.0.100 which uses Microsoft.NETCore.App 9.0.0, while bootstrap sdk version 9.0.200-preview.0.24523.19 uses Microsoft.NETCore.App 9.0.0-rc.2.24473.5. That's why CI failed to find the framework Microsoft.NETCore.App 9.0.0.

But if bootstrap sdk version is changed to 9.0.100, it will have the following problem https://dev.azure.com/dnceng-public/public/_build/results?buildId=880495&view=logs&j=20125c81-7edb-551b-693a-61efae016b74&t=7ce25265-aabe-59d3-d73c-06619cfcc3c4&l=168.

MSBUILD : error MSB1025: An internal failure occurred while running MSBuild.
This is an unhandled exception in MSBuild -- PLEASE OPEN A BUG AGAINST THE MSBUILD TEAM.
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
File name: 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at Microsoft.Build.Construction.SolutionFile.ParseUsingNewParser()
   at Microsoft.Build.Construction.SolutionFile.Parse(String solutionFile) in /_/src/Build/Construction/Solution/SolutionFile.cs:line 287
   at Microsoft.Build.Execution.ProjectInstance.GenerateSolutionWrapper(String projectFile, IDictionary`2 globalProperties, String toolsVersion, ILoggingService loggingService, BuildEventContext projectBuildEventContext, IReadOnlyCollection`1 targetNames, ISdkResolverService sdkResolverService, Int32 submissionId) in /_/src/Build/Instance/ProjectInstance.cs:line 2884
   at Microsoft.Build.Execution.ProjectInstance.CalculateToolsVersionAndGenerateSolutionWrapper(String projectFile, BuildParameters buildParameters, ILoggingService loggingService, BuildEventContext projectBuildEventContext, Dictionary`2 globalProperties, Boolean isExplicitlyLoaded, IReadOnlyCollection`1 targetNames, ISdkResolverService sdkResolverService, Int32 submissionId) in /_/src/Build/Instance/ProjectInstance.cs:line 2613
   at Microsoft.Build.Execution.ProjectInstance.LoadSolutionForBuild(String projectFile, PropertyDictionary`1 globalPropertiesInstances, String toolsVersion, BuildParameters buildParameters, ILoggingService loggingService, BuildEventContext projectBuildEventContext, Boolean isExplicitlyLoaded, IReadOnlyCollection`1 targetNames, ISdkResolverService sdkResolverService, Int32 submissionId) in /_/src/Build/Instance/ProjectInstance.cs:line 2577
   at Microsoft.Build.Execution.BuildManager.LoadSolutionIntoConfiguration(BuildRequestConfiguration config, BuildRequest request) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1476
   at Microsoft.Build.Execution.BuildManager.HandleNewRequest(Int32 node, BuildRequestBlocker blocker) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 2336
   at Microsoft.Build.Execution.BuildManager.ProcessPacket(Int32 node, INodePacket packet) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1605
   at Microsoft.Build.Execution.BuildManager.<>c__DisplayClass85_0.<Microsoft.Build.BackEnd.INodePacketHandler.PacketReceived>b__0() in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1187
   at Microsoft.Build.Execution.BuildManager.ProcessWorkQueue(Action action) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1558

It might be related to #10836 (comment), but not sure since the CI run doesn't exist currently.

@surayya-MS
Copy link
Member

let's wait for another update from arcade where BootstrapSdkVersion updates too

@JanKrivanek
Copy link
Member

let's wait for another update from arcade where BootstrapSdkVersion updates too

BootstrapSdkVersion updates are completely up on us.
@surayya-MS - when are the .slnx changes planned to be backported to 9.0.1xx?
Untill then we'll likely need to switch to preview of 9.0.2xx

@JanKrivanek
Copy link
Member

It seems that updating the BootstrapSdkVersion updates just the sdk, but not the runtime of our bootstrap

Executing [D:\a\_work\1\s\artifacts\bin\bootstrap\core\dotnet.exe D:\a\_work\1\s\artifacts\bin\bootstrap\core\sdk\9.0.200-preview.0.24523.19\MSBuild.dll Project1.csproj /m:1 -nr:False -restore -check]
        ==== OUTPUT ====
        You must install or update .NET to run this application.
        
        App: D:\a\_work\1\s\artifacts\bin\bootstrap\core\sdk\9.0.200-preview.0.24523.19\MSBuild.dll
        Architecture: x64
        Framework: 'Microsoft.NETCore.App', version '9.0.0' (x64)
        .NET location: D:\a\_work\1\s\artifacts\bin\bootstrap\core\
        
        The following frameworks were found:
          9.0.0-rc.2.24473.5 at [D:\a\_work\1\s\artifacts\bin\bootstrap\core\shared\Microsoft.NETCore.App]
        
        Learn more:
        https://aka.ms/dotnet/app-launch-failed
        
        To install missing framework, download:
        https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0&arch=x64&rid=win-x64&os=win10
        Process ID is 3712

@JanKrivanek JanKrivanek force-pushed the darc-main-ae7e245f-cd32-43c5-bf7e-da57c88bdd50 branch from abf2590 to 21535f6 Compare December 4, 2024 18:28
@JanKrivanek JanKrivanek enabled auto-merge (squash) December 4, 2024 18:29
@JanKrivanek
Copy link
Member

Turns out we really just need to update the bootsrap sdk version - in order to have the 9.0.1 runtime.
So @surayya-MS - you've been right
We just need to do it manually ourselves

@JanKrivanek JanKrivanek merged commit 2839cff into main Dec 5, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the darc-main-ae7e245f-cd32-43c5-bf7e-da57c88bdd50 branch December 5, 2024 06:19
@JanKrivanek JanKrivanek self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants