Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onepagers for MSBuildServer and RAR caching #11005

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

SimaTian
Copy link
Member

Onepagers as per our internal team discussion.

@SimaTian
Copy link
Member Author

Hello @tkapin @donJoseLuis, I went over the comments and answered what I could.
That being said I've got kind of a technical question - how much more in depth should I do in the next iteration please? (I will fill in the requested information that I put into the comments for now at the very least)
I'm aware I was probably too vague at some places and didn't explain deeply enough at others. Part of this I attribute to the fact that I was sticking to the "one pager" format. I was actively cutting some stuff away to keep the stuff as concise as possible with the hope to keep it contained on, well, one page.
I have no issue writing more so this is more of a check - what is an expected length of one pager please? I probably took it too literally.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional risk that I see is that this feature might end up like the caching plugin - something that only 1ES can use, and only on some platforms. We should ideally take an implementation interface that is

  • capable of cross-platform support
  • able to be used in an IPC manner as well as an in-proc manner (i.e. msbuild server)
  • able to be used both for Framework MSBuild and .NET MSBuild

@SimaTian SimaTian merged commit 99ab007 into main Dec 9, 2024
10 checks passed
@SimaTian SimaTian deleted the onepagers_RARcaching_MSBuildServer branch December 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants