Enhance MSB4019 message #10938
Merged
Enhance MSB4019 message #10938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10333
Context
Change the MSB4019 error message (
ImportedProjectNotFound) to include the unevaluated value of theImportelement'sProjectattribute.Changes Made
Changed the error message to use the wording proposed in the issue.
Added the unevaluated value of the
Projectattribute when the error message is used.Added a unit test for the MSB4019 error.
Testing
Tested manually with a test project file on Windows and macOS.
Tested by running all unit tests on Windows and macOS.
Notes
The unit test checks that a MSB4019 error is reported and that the unevaluated value is in the error message.