Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting fix according to IDE0055 #10922

Merged
merged 6 commits into from
Nov 7, 2024
Merged

formatting fix according to IDE0055 #10922

merged 6 commits into from
Nov 7, 2024

Conversation

SimaTian
Copy link
Member

@SimaTian SimaTian commented Nov 1, 2024

Context

I've had some issues with code review formatting suggestions. Most of those were avoidable via rule IDE0055 which is only a suggestion. This is a first rounds of changes to then hopefully make IDE0055.severity = warning toggle possible.

Changes Made

Formatting fixes.

Testing

No functionality has changed. Only formatting. Our current tests should still apply.

Notes

First commit is via hand, second via VS cleanup feature that I found later.

Copy link
Contributor

@maridematte maridematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few nits since the code in those is already being touched, but feel free to ignore them.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SimaTian SimaTian merged commit 8a5384d into main Nov 7, 2024
10 checks passed
@SimaTian SimaTian deleted the formatting-fix-vol1 branch November 7, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants