Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable workload resolver for amd64 too #10118

Merged
merged 1 commit into from
May 9, 2024
Merged

Disable workload resolver for amd64 too #10118

merged 1 commit into from
May 9, 2024

Conversation

KirillOsenkov
Copy link
Member

Fixes #7988

Follow-up for #10112

@KirillOsenkov KirillOsenkov requested a review from a team as a code owner May 7, 2024 18:25
rainersigwald
rainersigwald approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, SDK should be using $(MSBuildBinPath32) to avoid the need for this, but it's an empty file so let's do it.

@rainersigwald rainersigwald enabled auto-merge (squash) May 7, 2024 19:59
@baronfel
Copy link
Member

baronfel commented May 7, 2024

Ugh, SDK should be using $(MSBuildBinPath32) to avoid the need for this, but it's an empty file so let's do it.

Do we need to change something in the SDK to be future-proof?

@ladipro
Copy link
Member

ladipro commented May 9, 2024

Do we need to change something in the SDK to be future-proof?

To be correct 😉. SdkResolvers is supposed to exist only in the base MSBuild installation path, not in arch specific subdirectories.

@ladipro ladipro mentioned this pull request May 9, 2024
Merged
@rainersigwald rainersigwald merged commit 8632094 into main May 9, 2024
10 checks passed
@rainersigwald rainersigwald deleted the dev/kirillo/resolver64 branch May 9, 2024 08:51
ladipro added a commit to dotnet/sdk that referenced this pull request May 14, 2024
@ladipro
Fix DisableWorkloadResolverSentinelPath on .NET Framework (#40787)
1b6d660 
As pointed out in dotnet/msbuild#10118, we currently look for the file in arch subfolders such as `MSBuild\Current\Bin\amd64\SdkResolvers`), which doesn't look expected. `SdkResolvers` is present only under the base (x86) installation path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@ladipro ladipro ladipro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap MSBuild unable to build console projects: unable to resolve workload SDKs
4 participants
@KirillOsenkov @baronfel @ladipro @rainersigwald