-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Window Parent before initialize the child ContentPage #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested changes
Jul 11, 2022
dansiegel
reviewed
Jul 11, 2022
src/Controls/src/Core/HandlerImpl/Application/Application.Impl.cs
Outdated
Show resolved
Hide resolved
PureWeen
approved these changes
Jul 18, 2022
dansiegel
approved these changes
Jul 18, 2022
Redth
approved these changes
Jul 18, 2022
hartez
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
fixed-in-6.0.486
Look for this fix in 6.0.486 SR4!
fixed-in-7.0.0-rc.1.6683
t/bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Delay firing
appearing
on pages until the whole visual tree from app => page is setup. The reason this worked on shell is that shell delays creating pages until the platform asks for it so by that point the parent hierarchy will have been established.Issues Fixed
Fixes #8635