Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Set block to null when cancelled #8591

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[ios] Set block to null when cancelled #8591

merged 1 commit into from
Jul 7, 2022

Conversation

mattleibow
Copy link
Member

Description of Change

In newer versions of iOS, this is a non-nullable parameter, so it needs the check. But, we also should not be hanging onto a cancelled block.

Issues Fixed

None.

@mattleibow mattleibow changed the title Set block to null when cancelled [ios] Set block to null when cancelled Jul 7, 2022
@mattleibow mattleibow added platform/macOS 🍏 macOS / Mac Catalyst platform/iOS 🍎 t/housekeeping ♻︎ area-core-dispatching Main/UI threads, IDispatcher, IDispatcherTimer labels Jul 7, 2022
@mattleibow mattleibow added this to the 6.0-sr3 milestone Jul 7, 2022
@mattleibow mattleibow merged commit 3d81032 into net6.0 Jul 7, 2022
@mattleibow mattleibow deleted the dev/ios-null-block branch July 7, 2022 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@samhouts samhouts added the fixed-in-6.0.419 Look for this fix in 6.0.419! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-core-dispatching Main/UI threads, IDispatcher, IDispatcherTimer fixed-in-6.0.419 Look for this fix in 6.0.419! platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst t/housekeeping ♻︎
Projects
None yet
Milestone
6.0-sr3
Development

Successfully merging this pull request may close these issues.
2 participants
@mattleibow @samhouts