-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call disconnect on previous handler with Shell #8455
Conversation
I think I have found something similar with the WebView on Windows. Get a crash closing a Window with a WebView, mostly because doing that we are not invoking the Disconnect method. Will send a PR with changes but definitely I think this apply to the rest. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellRenderer.cs
Outdated
Show resolved
Hide resolved
|
@rmarinho fixed! |
When the fix will be available? |
Description of Change
When swapping in a new handler for shell call disconnect on the previous handler so that the xplat events don't trigger operations on the old set of handlers. There's a larger issue here where I think we need to call
SetVirtualView(null)
on the previous handler. Something not quite as involved as calling "Disconnect".#8456
Testing notes
To test this
Issues Fixed
Fixes #7940