Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix wrong RadialGradient on Border #8408

Merged
merged 1 commit into from
Jul 21, 2022
Merged

[Windows] Fix wrong RadialGradient on Border #8408

merged 1 commit into from
Jul 21, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix wrong RadialGradient on Windows Border.

image

Issues Fixed

Fixes #8361

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing labels Jun 29, 2022
@jsuarezruiz jsuarezruiz added this to the 6.0-sr3 milestone Jun 29, 2022
@rmarinho rmarinho requested review from mattleibow and rmarinho June 30, 2022 11:55
@rmarinho
Copy link
Member

Is it possible to add a test ? like check the the pixel at the bottom right?

@@ -59,6 +60,7 @@ public static partial class PaintExtensions
{
var brush = new WRadialGradientBrush
{
GradientOrigin = new WPoint(radialGradientPaint.Center.X, radialGradientPaint.Center.Y),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important change.

@hartez hartez self-assigned this Jul 21, 2022
@hartez hartez changed the base branch from main to net6.0 July 21, 2022 17:28
@hartez hartez modified the milestones: 6.0-sr3, 6.0-sr4 Jul 21, 2022
@hartez hartez merged commit 2eafe58 into net6.0 Jul 21, 2022
@hartez hartez deleted the fix-8361 branch July 21, 2022 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@samhouts samhouts added fixed-in-6.0.486 Look for this fix in 6.0.486 SR4! fixed-in-7.0.0-rc.1.6683 labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing fixed-in-6.0.486 Look for this fix in 6.0.486 SR4! fixed-in-7.0.0-rc.1.6683 platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadialGradientBrush with Center rendering is broken on Windows
4 participants