[Android] Avoid load icon if menu item is disposed #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
PureWeen
reviewed
Jun 23, 2022
| if (result is not null) | ||
| menuItem?.SetIcon(result.Value); | ||
| if (menuItem.IsAlive() && result is not null) | ||
| menuItem.SetIcon(result.Value); |
There was a problem hiding this comment.
Added the check here @jsuarezruiz
According to the exception the call fails here
at AndroidX.AppCompat.View.Menu.MenuItemImpl.SetIcon
Which makes sense because this is happening after the async/await so the menuItem has become disposed at that point
PureWeen
approved these changes
Jun 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Avoid load icon if menu item is disposed on Android.
Issues Fixed
Fixes #8101