Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set bounds for iOS ScrollView content holder #8002

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Jun 13, 2022

Description of Change

The content view which holds the content in an iOS ScrollView is getting its Bounds set. So while it lays out and scrolls with no issues, the hit testing thinks it has no size and never propagates gestures to the ScrollView content.

These changes explicitly set the bounds so that gestures will work.

@hartez hartez added this to the 6.0-sr2 milestone Jun 13, 2022
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirmed this fixed the regression I saw

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hartez hartez self-assigned this Jun 14, 2022
@hartez hartez changed the base branch from main to net6.0 June 14, 2022 18:22
@hartez hartez requested a review from a team as a code owner June 14, 2022 18:22
@hartez hartez marked this pull request as draft June 14, 2022 18:23
@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jun 14, 2022
@hartez hartez force-pushed the fix-ios-scrollview-hittesting branch from 4d94a9c to 9e60841 Compare June 14, 2022 18:45
@hartez hartez marked this pull request as ready for review June 14, 2022 18:45
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jfversluis jfversluis merged commit 0f13f06 into net6.0 Jun 17, 2022
@jfversluis jfversluis deleted the fix-ios-scrollview-hittesting branch June 17, 2022 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@Eilon Eilon added area-controls-scrollview ScrollView and removed area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels May 14, 2024
@samhouts samhouts added the fixed-in-6.0.408 Look for this fix in 6.0.408! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-scrollview ScrollView fixed-in-6.0.408 Look for this fix in 6.0.408!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants