[Android] Implement quit Application #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
changed the title
Redth
reviewed
May 31, 2022
|
|
||
| if (currentActivity != null) | ||
| { | ||
| if (OperatingSystem.IsAndroidVersionAtLeast(21)) |
There was a problem hiding this comment.
MAUI only supports 21+ already, so I don't think we need an extra check here.... Even after reading the android documentation, I'm still not super clear on which finish variant is the 'best' one here, but presumably if this code came from Forms, maybe we can track down the conversation/comments/PR around choosing it to be sure?
There was a problem hiding this comment.
Updated. Have removed the version validation.
Redth
approved these changes
Jun 1, 2022
mattleibow
approved these changes
Jun 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement quit App on Android.
Issues Fixed
Fixes #7255