-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate semantics to CV Item container #7539
Conversation
{ | ||
// If you don't set the automation properties on the root element | ||
// of a list item it just reads out the class type to narrator | ||
// https://docs.microsoft.com/en-us/accessibility-tools-docs/items/uwpxaml/listitem_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we consider changing the default too? So that if a developer doesn't explicitly set a description, it'll still make sense?
Maybe we can do something similar to image where it simply can't receive focus at all and won't read out anything - maybe we can make it so just the contents are accessible?
Or alternatively, we can try to make the textual contents or at least the first textual content get propagated upward
{ | ||
// If you don't set the automation properties on the root element | ||
// of a list item it just reads out the class type to narrator | ||
// https://docs.microsoft.com/en-us/accessibility-tools-docs/items/uwpxaml/listitem_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we consider changing the default too? So that if a developer doesn't explicitly set a description, it'll still make sense?
Maybe we can do something similar to image where it simply can't receive focus at all and won't read out anything - maybe we can make it so just the contents are accessible?
Or alternatively, we can try to make the textual contents or at least the first textual content get propagated upward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a first step!
works as expected on Recipes as well :)
failing tests unrelated |
Description of Change
If you don't set the AutomationProperties on the root element of a templated ListViewItem in WinUI then it just reads out the class type on Narrator. In order to read out something useful the guidance is to set the
AutomationProperties
of the root element. This PR propagates the semantic properties set on the root xplat element to theContentControl
that acts as the root container for the WinUI CV.Example Usage