Merge the PublicAPI checker into main #7339
Conversation
Eilon
added
the
area-infrastructure
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Now a new one: error RS0016: Symbol 'Auto' is not part of the declared API |
This needs to be moved again for net7, and obsoleted instead of deleted.
| public static SpannableString ToSpannableString( | ||
| this FormattedString formattedString, | ||
| IFontManager fontManager, | ||
| TextPaint? textPaint = null, |
There was a problem hiding this comment.
Using TextPaint was incorrect as it did not represent the span size but the label. So the label would have a tiny font size and the span huge, but then layouts would measure line heights using the tine label size.
There was a problem hiding this comment.
Same as Windows. The above overload is the correct one.
| double defaultLineHeight = -1d, | ||
| double defaultLineHeight = 0d, // TODO: should be -1, but too late to change for net6 |
There was a problem hiding this comment.
Not super essential as this is just the default value and was passed in via the call above. This overload really should have been internal.
| double defaultLineHeight = -1d, | ||
| double defaultLineHeight = 0d, // TODO: should be -1, but too late to change for net6 |
There was a problem hiding this comment.
Same as Windows. The above overload is the correct one.
| override Microsoft.Maui.Controls.ContentView.OnApplyTemplate() -> void | ||
| override Microsoft.Maui.Controls.Grid.OnBindingContextChanged() -> void | ||
| ~override Microsoft.Maui.Controls.Handlers.Compatibility.ViewCellRenderer.DisconnectHandler(Android.Views.View platformView) -> void |
There was a problem hiding this comment.
Are overrides really breaking?
There was a problem hiding this comment.
Good question, i wouldn't think so.
This corrects a mistake in the #7339
Description of Change
Errors at the moment:
error RS0016: Symbol 'DidDisconnect' is not part of the declared API
error RS0016: Symbol 'SetEmptyBorderBrush' is not part of the declared API
error RS0017: Symbol 'Microsoft.Maui.Platform.RootPanel' is part of the declared API, but is either not public or could not be found
error RS0017: Symbol 'Microsoft.Maui.Platform.RootPanel.RootPanel() -> void' is part of the declared API, but is either not public or could not be found
Issues Fixed
Fixes #