Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Clip Border content based on StrokeShape property #7335

Merged
merged 5 commits into from
Jun 24, 2022
Merged

[iOS] Clip Border content based on StrokeShape property #7335

merged 5 commits into from
Jun 24, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented May 19, 2022 •
edited
Loading

Description of Change

Currently is not implemented:

Captura de Pantalla 2022-05-19 a las 13 57 26

We implemented it on Android and Windows: #5789

This PR include changes to clip the Border Content based on StrokeShape property:
clip-border-ios

Fixes #7475
Fixes #7493
Fixes #8381

@jsuarezruiz jsuarezruiz added area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/iOS 🍎 labels May 19, 2022
@jsuarezruiz jsuarezruiz marked this pull request as ready for review May 24, 2022 10:19
This was referenced May 25, 2022
Closed
Closed
@jsuarezruiz jsuarezruiz added this to the 6.0.3xx-sr1 milestone May 27, 2022
mattleibow
mattleibow requested changes Jun 2, 2022
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureWeen the code looks valid, but the dispose scares me.

@Redth Redth changed the base branch from main to net6.0 June 3, 2022 16:30
@hartez hartez modified the milestones: 6.0-sr1, 6.0-sr2 Jun 6, 2022
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner June 10, 2022 11:53
@jsuarezruiz jsuarezruiz changed the base branch from net6.0 to main June 10, 2022 11:53
@jsuarezruiz jsuarezruiz changed the base branch from main to net6.0 June 10, 2022 11:59
@jsuarezruiz jsuarezruiz changed the base branch from net6.0 to main June 10, 2022 12:00
@jsuarezruiz jsuarezruiz changed the base branch from main to net6.0 June 10, 2022 12:04
@hartez hartez requested a review from PureWeen June 13, 2022 16:55
rmarinho
rmarinho requested changes Jun 21, 2022
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, also can we remove the dispose?

@rmarinho rmarinho force-pushed the border-clip-ios branch 2 times, most recently from a699130 to d4707e6 Compare June 23, 2022 12:10
@rmarinho rmarinho requested review from rmarinho and mattleibow June 23, 2022 13:47
@rmarinho
Copy link
Member

@jsuarezruiz @mattleibow i removed the dispose When the ContentView goes away , the layer should bealso grabbed and dispoed, no need to set to null, right @PureWeen ?

@rmarinho rmarinho merged commit 275797d into net6.0 Jun 24, 2022
@rmarinho rmarinho deleted the border-clip-ios branch June 24, 2022 10:55
This was referenced Jun 29, 2022
Closed
Closed
@jsuarezruiz jsuarezruiz mentioned this pull request Sep 6, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.408 Look for this fix in 6.0.408! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow

Assignees

@jsuarezruiz jsuarezruiz

Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing fixed-in-6.0.408 Look for this fix in 6.0.408! platform/iOS 🍎
Projects
None yet
Milestone
6.0-sr2
6 participants
@jsuarezruiz @rmarinho @mattleibow @PureWeen @hartez @samhouts